Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ewelink websocket #1977

Closed
wants to merge 11 commits into from
Closed

Ewelink websocket #1977

wants to merge 11 commits into from

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Dec 12, 2023 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Changes eWeLink API with OAuth2 authentication.
Implements WebSocket connection as recommanded in developer documentation.

Documentation: GladysAssistant/v4-website#232

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (185fe8a) to head (589bd11).
Report is 33 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1977      +/-   ##
==========================================
+ Coverage   98.32%   98.39%   +0.06%     
==========================================
  Files         836      860      +24     
  Lines       13269    13469     +200     
==========================================
+ Hits        13047    13253     +206     
+ Misses        222      216       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atrovato atrovato force-pushed the ewelink-websocket branch 7 times, most recently from a095650 to b0f7022 Compare December 15, 2023 19:06
@atrovato atrovato mentioned this pull request Dec 15, 2023
Closed
@atrovato atrovato force-pushed the ewelink-websocket branch 2 times, most recently from a76f65d to d72b4e5 Compare December 15, 2023 19:24
@atrovato atrovato mentioned this pull request Jan 10, 2024
Closed
9 tasks
@stale Stale
Copy link

stale bot commented Apr 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 26, 2024
@stale stale bot closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atrovato